Add tests for Project Euler Problem 5 + minor refactor #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hrown error in case of invalid input
pomkarnath98
requested review from
raklaptudirm and
appgurueu
as code owners
…ascript into project-euler-5
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1691 +/- ##
==========================================
+ Coverage 84.65% 84.76% +0.10%
==========================================
Files 378 378
Lines 19744 19742 -2
Branches 2952 2956 +4
==========================================
+ Hits 16715 16735 +20
+ Misses 3029 3007 -22 ☔ View full report in Codecov by Sentry. |
|
@raklaptudirm @appgurueu I have formatted the code with Prettier. But the Codecov report says, |
|
As the codecov report shows, the trivial error check is not tested (see https://app.codecov.io/gh/TheAlgorithms/JavaScript/pull/1691/blob/Project-Euler/Problem005.js). I would probably just remove it. |
|
@appgurueu @raklaptudirm I think this PR now can be reviewed and merged. |
raklaptudirm
previously approved these changes
Oct 4, 2024
appgurueu
reviewed
Oct 7, 2024
appgurueu
changed the title
appgurueu
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.